Peter Newman

Results 814 comments of Peter Newman

I've had a quick look, and I'm inclined to point the finger at the NULL here, but I've not been able to fix it yet: https://github.com/OpenLightingProject/ola/blob/master/tools/ola_trigger/Action.cpp#L159

> Not sure if this is helpful, but I often have installations where the machine is intentionally cut off from the internet after install. Yeah I figured that might be...

What does config.log say @DaAwesomeP ? Given it's present but can't be compiled, it could also be #1879 but seems unlikely if it works during a native build... Have you...

Also your Git-Fu is clearly much better than mine getting it targeting 0.10 branch, well done!

> > I'm not sure if this was my error or yours, but there's one outstanding lint issue remaining if you wouldn't mind. > > It should be fixed now....

> I tweaked the code as you've suggested - thanks for the feedback! Hopefully, this PR can be included in 0.10.9. 🤞 > Unfortunately, it looks like I've somehow messed...

FWIW, although we've just cut 0.10.9, I'm planning to roll out 0.10.10 within the next few days ideally, or few weeks if a few key outstanding PRs like this one...

If you read why it's failing: https://travis-ci.org/OpenLightingProject/ola/jobs/371260377#L7175 ``` +./scripts/verify_trees.py ./ ola-0.10.6 Missing from tarball yocto/recipes-conectivity/ola/ola_git.bb --------------------------------------- Either add the missing files to the appropriate Makefile.mk or update IGNORE_PATTERNS in scripts/verify_trees.py...

> > So you need to probably add a Makefile for that directory and add it to that. > > Oh, I know nothing about autotools. That's easy, see the...