Peter Newman

> I mean, if the message is stored somewhere for later retrieval then it will be self-contained if it _does_ contain the tuple, however, the system that stores it could...

> Would you mind splitting this into PRs having related commits? (And related commits squashed together.) If you merge #1 and I update, the Codespell stuff will disappear from this....

I've left my comments in #12 as they felt sufficiently different from this PR (and important enough to be worthy of their own issue rather than buried in a random...

> Please split unrelated changes into different PRs. I've now resynced this PR with master so it just has the validation commits left in it. Although as you'll see/as you...

> @peternewman @ssilverman I think, now that the `manufacturer_id` issue has been resolved, it would be possible to merge this in as well? Yes mostly @Bartel-C8 . Queued message fails...

I could, or you could just use the Squash and Merge option, which is probably less effort all round: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-pull-request-commits You might need to enable it first: https://docs.github.com/en/github/administering-a-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

Is the Squash and Merge option acceptable @ssilverman or do you want me to have a go from my end?

> I'm familiar with squash merges, I just wanted to give you an opportunity to create your own commit message. If you don't want to, I'll just create a commit...

Can I start with a meta comment @sammysmallman . From past similar discussions in other repos, I'd say these are numerous separate issues, and so some threading of discussion would...

Sorry this is a bit long... So I'll state categorically that neither OLA nor the Open Lighting RDM website/PID store ( http://rdm.openlighting.org/ ) will be able to use this schema...