Peter Newman

Results 814 comments of Peter Newman

> Let me be even more specific with my questions: > > 1. If you're a widget and you receive a Discovery MUTE for broadcast from OLA (Label=7), how should...

> I got everything working. All your comments were very helpful, thank you. Glad to hear it. I don't suppose you could summarise where you needed to send the timeouts...

Regarding "check what happens if we find a 'hidden' sensor, prob. print an advisory. " We return "GetSensorDefinition: Found too many 2/1 sensors", so I think we can tick that...

Although I think in this case the error was not returning enough sensors in DEVICE_INFO, rather than intentionally trying to hide it.

We should also try setting an invalid date.

We should also test factory defaults, or see if they change when we've set other stuff.

Can we not do i based on adding the information to the PIDs as discussed previously? ii and iii sound good. I was going to add some similar stuff for...

Fair point, I guess an out of range get could upset something for example.

More test work being done here https://github.com/OpenLightingProject/ola/pull/1067

If a test fails due to timeout, look at retrying after a short delay (flag as warning), try again, then if it still fails move on.