Peter Makowski

Results 37 comments of Peter Makowski

Absolutely, feel free to do so - I'm not 100% happy with how it looks yet, your original coffeescript was much cleaner and minified JavaScript was smaller. I not only...

Hey, I made quite a few changes, please review (look at the commit message). Could you let me know what else would you need before merging to the master branch?...

Sounds good! Actually I managed to fix Firefox issue just now https://github.com/d4nyll/lethargy/commit/332fe29b73dcce58cae9234aee1d8046ca9b66fb.

I tested `.u-off-screen` when used for visually hidden form element labels (e.g. search box in MAAS UI). Removing the fixed `1px` height has no effect on the assistive technology's ability...

We decided to close this for now. We can get much more value from e2e tests: https://github.com/canonical/vanilla-framework/pull/4540

This still appears to not be working correctly, e.g.: https://github.com/canonical-web-and-design/ubuntu.com/pull/11604

> @petermakowski do you know which specific colour contrast issue this is referring to? I think it's only within navigation, e.g.: ![image](https://user-images.githubusercontent.com/7452681/137133299-e6956c81-1607-4e7d-9841-f5112bfc6e11.png)

I also have this issue.

I do have premium, but have the same issue.

I am also experiencing this issue. Also, here: https://github.com/canonical/maas-ui/issues/4567#issuecomment-1327972499