peterlimg

Results 31 comments of peterlimg

@Dmdv we only need to limit the MPT object size at the moment, checking the string length could be done `post-mainnet`, as we may need to do through msgp tag...

@Dmdv the object size need to be checked with every insert, check here https://github.com/0chain/0chain/blob/a8f045c6d96a9f3c021a8126e5476236618024f7/code/go/0chain.net/core/util/merkle_patricia_trie.go#L133-L136

@Sriep smart contracts should be fine, we need to adjust the rate limit for none smart contracts APIs.

@dabasov the issue I mentioned was still there, perhaps fix it in another PR.

This is a known issue that I mentioned before, mainly the wrong URL address, the correct one should be https://dev-mobile.devnet-0chain.net/sharder01/v1/screst/6dba10422e368813802877a85039d3985d96760ed844092319743fb3a76712d7/getblobbers

@0xhrsh the system tests is failing because the faucet `config.ID` is initialized. I'll merge my fixes.

The [scConfigKey](https://github.com/0chain/0chain/blob/8fe25622400d719d6bffd9deb907edf5238cea37/code/go/0chain.net/smartcontract/vestingsc/config.go#L66) is different from the `VESTINGSC_CONFIG_KEY`, which caused the config read API handler get different config value. @0xhrsh please fix it, and remove the `scConfigKey` to avoid it being...

All the clients that using the current APIs should be adjusted too, mainly in gosdk I think, could also be used by frontend team (not sure). So we'd better knowing...

Initialize config to MPT in genesis block can be a separate task, this is needed for mainnnet but spliting the config files is not a must for mainnet ATM.