peterhoneder

Results 11 comments of peterhoneder

I think this shouldn't be an exception, but just fall into the default path of attribute handling. My approach to this is here: https://github.com/wichert/pyrad/pull/101 Basically my reasoning is, that you...

whenever you try setting the ip setting for the ingressEndpoint, make sure you are not setting publishedService, because it will override the IP setting and then it won't work

Hi! We currently receive sporadic errors of the following kind when subscribing to topics: "not currently connected and ResumeSubs not set" The issue here is, if you tcpdump, there is...

> kOps dns-controller the proposed PR currently does not change that behavior, but yes the existing implementation of the non kops compatible code path would only use NodeIPs from host...

Hi! my change does not affect the behavior for host-networking. It only allows an additional behavior for *non* host-networking pods, where the PodIP *is* correctly populated, and must be used...

> To be clear, I was not asking this PR to fix the handling of kOps requirements. It does not make things worse. ok, thanks, perfect 😄 just wanted to...

> @peterhoneder Do you think you can rebase this PR and takes into account review comment from @szuecs ? yes, I will do that

> @peterhoneder Do you think you can rebase this PR and takes into account review comment from @szuecs ? I rebased the PR and added more tests and more explicit...