Peter Zhang

Results 70 comments of Peter Zhang

ping @sgiehl, this happens when `addTracker` and `setCookieConsentGiven` are set, as described the `_pk_id ` will change, but not sure is a bug or expected.

@sgiehl I got an idea not sure if I am correct, I move the Corshandler to the Tracker main, works on my local, but I update Corshandler a little, will...

@sgiehl @MichaelRoosz rewrite `CORSHandler`a little bit hopefully that makes more sense.

@sgiehl trying to think of a test, is there a function I can use to do a fake cors request?

@bx80 Trying to add below in the `setUp` to test the config, but it seems like the test config won't update config. any ideas? ```php $testingEnvironment->overrideConfig('General', 'cors_domains', 'https://example.com', true); ````

@bx80 the old function doesn't accept array, I extend the function, the last param `true` accept arrary

@bx80 tried all kinds of different ways, but the config still won't set, any suggestions?

@bx80 figure out why, if all the tests are passed will request a review

@sgiehl revert some unnecessary code form change. that should make review easier.