Peter Fox

Results 10 comments of Peter Fox

@RemiCollin little to none except it makes a much more clear structure for delivery. It separates the who, what and where into notifiable, notification and channel. You can easily do...

You should be able to fix this by looking at x-forwarded-port check if it doesn't match the internal server, for instance an SSL proxy will give 443 while the server...

I'm also having this issue, my guess it it's a permissions issue somewhere and not the library, but it's frustrating

Can confirm, fixed the problem for me.

There's no try catch statements or switch case statements... but +1 for getting this added

I'd suggest adding pluggable events to this. E.g. one to check before impersonation has occurred that can block it by returning false in the same way Send events allow. Another...

@Vision42 I was unable to push fixes directly to your branch but I've created a patch file. [cockroachdb-laravel-320d3be-Add mechanism to handle failing with outdated DBAL.patch](https://github.com/ylsideas/cockroachdb-laravel/files/14623419/cockroachdb-laravel-320d3be-Add.mechanism.to.handle.failing.with.outdated.DBAL.patch) What my changes do, is...

@Vision42 thanks for the bug report. This might be a difficult one as DBAL is it's own thing to begin with. I don't know if there is any project covering...

@Vision42 it looks good for the latest versions of Laravel 10 but using the lowest compatible packages and older versions of Laravel the tests fail. Hard to get a good...

@Vision42 It would likely break older versions although it's always hard to tell. It might be a case that your fix lives in the package but has to be switched...