Peter Výboch
Peter Výboch
This is a duplicate of #47 , seems like maintainers no longer works on this. I have worked on it a bit in my fork and it now compiles but...
Tests need rework to separate the concerns, currently tests overlap and test multiple things at once
Absolutely necessary to at least separate tests which verify prints and the ones that verify output of functions, this is a source of constant issues
Tests need rework to separate the concerns, currently tests overlap and test multiple things at once
Another issue seems to be that Ctrl+C behavior is not properly tested, look at readchar is necessary to understand how to test that.
Hey, @MatanRubin , it seems to be one indent too deep [here](https://github.com/MatanRubin/beaupy/blob/e0c209b3e59831381cba9d5a4693d18b31949c41/beaupy/_internals.py#L58). I have set up some tasks. You could try running `poetry run poe lint` for formatting and linting...
@MatanRubin Splendid, thanks! I am aware some refactoring is warranted, if you find time I am definitely happy to accept a PR. Anyways, seems like multiline input is failing on...
Okay, I have checked, it expects `\r\n` as a line break on Windows. However it seems `click.getchar` is a tremendous mess on Windows (or maybe it's Windows that is the...
So this seems to be a major pain-point. I've tried several solutions, from purely Pythonic to C extensions. Generally all fail to tell the difference between `Ctrl+Enter` and `Enter`.
@MatanRubin I don't think I can merge this as is. We either would need a different handling on Windows for the end of multiline prompt, or this could be marked...
> I agree we shouldn't merge this before making sure it works on all platforms. It's weird that your mac doesn't interpret alt-enter differently than enter. Mine does... > >...
@MatanRubin went ahead to try it now but it turns out I can no longer boot my testing Windows. I will need to get myself a new instance of Windows,...