robotics-toolbox-python icon indicating copy to clipboard operation
robotics-toolbox-python copied to clipboard

fix: remove unused imports on EKF.py

Open FelipeCybis opened this issue 1 year ago • 9 comments

  • Close #412

Indeed, in the latest scipy release (1.12.0), they removed the, already deprecated, scipy.randn function. (The deprecated warning said they would remove at 2.0.0, but well...).

In robotics-toolbox-python there was one place where from scipy import randn was called: the roboticstoolbox/mobile/EKF.py but it was not used. Instead of limiting scipy<1.12.0, I removed the unused dependency (and a few others in the same file).

FelipeCybis avatar Jan 22 '24 16:01 FelipeCybis

Second this MR as it is currently breaking the normal installation and usage of the toolbox :+1:

kingjin94 avatar Jan 26 '24 14:01 kingjin94

@petercorke @jhavl Sorry to bother, but could you guys have a look at this? scipy is a big package and, currently, we cannot use the latest version of it with robotics-toolbox-python :)

FelipeCybis avatar Feb 13 '24 10:02 FelipeCybis

Can confirm that this is causing issues on conda-forge as well ..

Tobias-Fischer avatar Feb 23 '24 02:02 Tobias-Fischer

Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best.

cpieringer avatar Apr 12 '24 15:04 cpieringer

Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best.

Yep, it should be. You can see the last commit in main is on my fork directly before my fix.

FelipeCybis avatar Apr 12 '24 15:04 FelipeCybis

Thanks for fixing this, @FelipeCybis. @petercorke @jhavl should definitely merge this pull request, so the package can be used with the latest version of scipy

seanjaffe1 avatar Apr 17 '24 19:04 seanjaffe1

I have the same issue on up-to-date Ros2 humble. This is very simple and fixes everything.

2lian avatar May 04 '24 08:05 2lian

Please merge this.

ntorresalberto avatar May 04 '24 14:05 ntorresalberto

@petercorke @jhavl Bumping this again. This is a critical bug with an easy fix, please merge asap.

EDIT: I can see this change has been made already in 2731430 , please disregard

TJMolnar avatar May 21 '24 00:05 TJMolnar

Thanks for flagging this, this has been fixed on future branch to be incorporated in the next release.

jhavl avatar Jul 29 '24 04:07 jhavl