robotics-toolbox-python
robotics-toolbox-python copied to clipboard
fix: remove unused imports on EKF.py
- Close #412
Indeed, in the latest scipy
release (1.12.0), they removed the, already deprecated, scipy.randn
function. (The deprecated warning said they would remove at 2.0.0, but well...).
In robotics-toolbox-python
there was one place where from scipy import randn
was called: the roboticstoolbox/mobile/EKF.py
but it was not used. Instead of limiting scipy<1.12.0
, I removed the unused dependency (and a few others in the same file).
Second this MR as it is currently breaking the normal installation and usage of the toolbox :+1:
@petercorke @jhavl Sorry to bother, but could you guys have a look at this? scipy
is a big package and, currently, we cannot use the latest version of it with robotics-toolbox-python
:)
Can confirm that this is causing issues on conda-forge as well ..
Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best.
Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best.
Yep, it should be. You can see the last commit in main is on my fork directly before my fix.
Thanks for fixing this, @FelipeCybis. @petercorke @jhavl should definitely merge this pull request, so the package can be used with the latest version of scipy
I have the same issue on up-to-date Ros2 humble. This is very simple and fixes everything.
Please merge this.
@petercorke @jhavl Bumping this again. This is a critical bug with an easy fix, please merge asap.
EDIT: I can see this change has been made already in 2731430 , please disregard
Thanks for flagging this, this has been fixed on future branch to be incorporated in the next release.