Peter Broadhurst comments

Results 86 comments of


                                            Peter Broadhurst

Migration to v1.3.0 can cause missed events when contract listeners are listening from latest

So just thinking about the implications, it will simply be that the `listener` in `EVMConnect`/`fabconnect` will show a `fromBlock` that isn't the only you specified on the listener itself. I...

Migration to v1.3.0 can cause missed events when contract listeners are listening from latest

I've updated the PR to handle the `0` and explicit block cases for Fabric and Ethereum

Bug at startup where FireFly gives up creating listeners if cannot reach transaction manager

> This will cause FireFly to never listen to those events and not let the user know that an issue has occurred. It's a bug in the way the Contract...

Bug at startup where FireFly gives up creating listeners if cannot reach transaction manager

Note that I expect the testing, code changes and investigation of this one to overlap with the changes under discussion in #1531

Bug at startup where FireFly gives up creating listeners if cannot reach transaction manager

Thanks @EnriqueL8 - going to take another look my side to understand the code better. My naive reading of the code suggested that if `err != nil` in the below...

Bug at startup where FireFly gives up creating listeners if cannot reach transaction manager

Ok - so the thing I missed here is the `true` being passed down for `okNotFound`, so the `FF10111` error isn't actually passed to this code. So I don't think...