Peter Broadhurst
Peter Broadhurst
Before I re-review here @EnriqueL8 - can you provide a new summary (either editing the header, or providing it below) of the externals changes. I referenced one detail point here:...
For `?filters=` - I think you're just missing an entry here: https://github.com/hyperledger/firefly/blob/c2c5a9551c2538cfde3d2ecc59b657cf09d3293f/pkg/database/plugin.go#L1051-L1063
The wrinkle here, is that SubscriptionFilter applies filters as a Regular Expression, and currently we don't have support for regular expression filters in our DB semantics. So I think the...
Example of how this can be acheived: ``` { "jsonrpc": "2.0", "id": 1, "method": "debug_traceTransaction", "params": ["0x5126bbcb9b77a26fecd2ece4b8c96e2794aaccd997fa6beffb06a0405dc270b2", {"enableReturnData": true}] } ``` ```js "jsonrpc": "2.0", "id": 1, "result": { "gas": 21476,...
There does seem to be a well worked function for this in fact: https://github.com/hyperledger/firefly-evmconnect/blob/35424990511fcc7677840ee8f335a4bd24684050/internal/ethereum/get_receipt.go#L145-L176
I do see the error going into `receipt.extraInfo.errorMessage` for EVM:
Above was a simple `revert`, but here I see with a structured error it can't be decoded - so the problem might be the ABI definition of the errors aren't...
For ref, the simple contract I'm using is: ```solidity pragma solidity ^0.8.0; contract reverter { uint public storedData; error Pop(string message, uint256 value); constructor() {} function pop1() pure public {...
Yes - that's the problem. We need to work on FFTM to pass through the error structure from the original TX down into the `TransactionReceiptRequest` to be able to decode...
Ok - FFTM does not actually store the error ABI details, they are held in FireFly core and only passed on prepare. They are a big glob of JSON that...