Peter Bourgon

From #33, > It looks like LocalConnection would not need to exported either if it implemented an interface with an OverlayConn method, so the likes of https://github.com/weaveworks/weave/blob/master/router/network_router.go#L189 can use that...

https://github.com/weaveworks/mesh/pull/7/files#r53569111

https://github.com/weaveworks/mesh/pull/11/files#r53553124

https://github.com/weaveworks/mesh/pull/12/files#r53552988

This is a transplant of https://github.com/weaveworks/weave/issues/1867. Quote, > When a peer restarts quickly, not all other peers necessarily see the peer go away, since topology gossip data merging may combine...

Package name should be useragent, not user_agent

2

> By convention, packages are given lower case, single-word names; there should be no need for underscores . . . https://golang.org/doc/effective_go.html#package-names > Good package names . . . are lower...

Performance implications of enabling tracing?

1

Can these be documented somewhere? Of, if they are documented, can you point me to them? :)

``` $ golint . | wc -l 111 ```

Service created by `fastly compute deploy` isn't saved to manifest if deploy fails

1

If you `fastly compute deploy` and it decides to create a service for you, but your deploy fails, that service ID isn't saved to the fastly.toml file. It should be...