Peter Bourgon
Peter Bourgon
It is not a preference, it is a requirement. Your service should still return errors directly, e.g. ```go type FooService interface { Bar(int) (string, error) } ``` it is only...
Hmm, it could be either. The easiest fix would be to update the docs to mention it can panic, but a better fix would probably be a new constructor with...
I don't think Delete is the answer — metrics generally should be singletons in your component graph. If we need something more it would probably be to take an explicit...
You can do this without explicit support in Go kit, can't you?
Feel free to make a PR but consider it a method of explanation, as I don't yet understand why this is important.
Would be happy to review.
Metrics are being refactored for the next release; although there is no ETA, this work is probably not worth doing...
Yes. The current version of the metrics package also does this just fine, for the record; just not with the Provider interface. ``` c := multi.NewCounter( prometheus.NewCounter(...), expvar.NewCounter(...), ) ```
I don't think code like this needs to live in the Go kit repo. Do you agree? If so, I would be happy to link to your implementation.