peter-michalski

Results 51 comments of peter-michalski

@balacij, correct me if I am wrong, but it appears that we do not run `make deploy` in the Actions workflow. I had thought that `deploy` was run to generate...

> do we want to piggyback on Haskells type system fully, partially, or minimally? @balacij, could you please elaborate (as much detail as possible would be appreciated) on what it...

The above problem was resolved. This issue can be closed after #3047 is closed.

> E266 too many leading '#' for block comment https://github.com/JacquesCarette/Drasil/blob/84272acccc09574dec70d8d96c6ea994f15f8b22/code/drasil-gool/lib/GOOL/Drasil/LanguageRenderer/PythonRenderer.hs#L763-L768 Updating `pyDocCommentStart = pyCommentStart pyCommentStart` to `pyDocCommentStart = pyCommentStart` will fix this error. >E203 whitespace before ':' This is bit...

I recall a comment a few weeks ago that suggested that `SystemInformation` could be pulled out of `Body.hs` as we expand the list of generated artifacts, implying that it would...

> Data structure for holding all of the requisite information about a system >to be used in artifact generation. I was commenting that `SystemInformation` does not belong in Body.hs files...

A few outstanding items (potential new Issues): 1. `Goal` `Sentences` are capitalized and do not render nicely in the README. I'm wondering if `Sentences` in Drasil should instead be lowercase...

My initial concern is about readability. Especially pertaining to at least some of the chunks if the chunk descriptor is removed.