Drasil icon indicating copy to clipboard operation
Drasil copied to clipboard

`drasil-website`: "Package: drasil-all-pkgs-deps" graphs don't show up

Open balacij opened this issue 2 years ago • 4 comments

https://jacquescarette.github.io/Drasil/

At the bottom of the websites homepage, the "all package dependencies" graphs appear to be broken.

balacij avatar Sep 06 '22 23:09 balacij

Looks like make packagedeps was not run

peter-michalski avatar Sep 07 '22 00:09 peter-michalski

Ah, do we just need to add that to our Actions workflow then?

balacij avatar Sep 07 '22 00:09 balacij

@balacij, correct me if I am wrong, but it appears that we do not run make deploy in the Actions workflow.

I had thought that deploy was run to generate the website and had added packagedeps there.

I can add packagedeps to graphs to fix the issue,

graphs: $(GRAPH_PACKAGES) packagedeps ,

but am now wondering what deploy is actually used for. It is only for testing locally?

peter-michalski avatar Sep 07 '22 13:09 peter-michalski

Yep, make deploy is meant for local development. scripts/deploy_wrapper.bash and make deploy_lite together are a stripped down version of it, specifically intended for deploying the website. I think this was done a long time ago to have the CI steps highlight a bit more, to not just have the CI "steps" be a single gigantic make deploy command that hides information. More information about this should be in the Makefile and the deploy_wrapper.bash files.

I think that adding packagedeps as a dependency of the graphs target is a good idea too.

balacij avatar Sep 07 '22 16:09 balacij

This can be closed with #3050

peter-michalski avatar Sep 28 '22 11:09 peter-michalski