Peter Evans

Results 396 comments of Peter Evans

I've created a PR for @dabrahams' suggestion. https://github.com/hylo-lang/hylo/pull/1298 ``` let e = try state.apply(parseExpr(in:), expecting: .typeExpression) ``` I didn't attempt the larger refactor idea (`nextInput.parse`). Perhaps that could be a...

Hi @dmohns It's not clear to me from the documentation whether these tokens support the [API this action uses](https://github.com/peter-evans/dockerhub-description/blob/main/src/dockerhub-helper.ts#L39-L45). `Push and Pull` doesn't seem like the right scope to me....

Hi @gjrtimmer Please could you explain further. I don't understand why arch has anything to do with this action. Are you talking about executing the Docker container mentioned [here](https://github.com/peter-evans/dockerhub-description?tab=readme-ov-file#using-the-docker-image-independently-of-github-actions)? In...

Looks like the default for these assert functions is now `#file` not `#filePath`. Let me know if I'm completely off-base, but would the solution to this involve wrapping the calls...

I think a library would be preferable to symlinking. Symlinking in codebases can often cause problems, and behave differently across environments.

> you might look into adding overloads to create an ambiguity (at worst) or (better) @available annotations that can guide testers toward the better functions. I couldn't find a satisfying...

I just received a really helpful PR here: https://github.com/peter-evans/create-pull-request/pull/3475 And that lead me to realise that proxy support can be simplified to this: https://github.com/peter-evans/create-pull-request/pull/3483 It passes the [proxy support tests](https://github.com/peter-evans/create-pull-request-tests/actions/runs/11664524117)...

> It looks like you use `node-fetch-native` as a dependency which depends on `node-fetch`, which is a huge dependency. We try to keep this action slim, so I'd like to...