Peter von der Ahé

String interpolation specification refers to unspecified "concatenation"

2

String interpolation is defined like this: "An interpolated string ‘s1${e}s2’ is equivalent to the concatenation of the strings ‘s1’, e.toString() and ‘s2’." But what does "concatenation" mean. I suggest that...

There's probably a leak in dart2js' World._subtypes

1

I don't think forgetElement removes a class from World._subtypes. @johnniwinther

For example, a modified version of `tests/unsorted/10_test.dart`: ``` import 'package:expect/expect.dart'; class A { A() { } a() { return 12; } } class B extends A { b() { return...

Configurable userid of Fletch Agent

1

It should be possible to run the Fletch Agent as any user id.

We should have a test.py runtime that uses the Fletch Agent, so we can run all our tests where they get run via the agent.

kill_task.py isn't run after a failed test run.

1

As we can see from the screen shot below (from [target-dartino-linux-release-arm build 768](https://uberchromegw.corp.google.com/i/client.fletch/builders/target-dartino-linux-release-arm/builds/768)), `task_kill.py` isn't called after a failing test run. This means the next build also fails. ![screen shot...

These language tests crash after Dart roll (28787d81b04bebcb0dca924d58330e0760c6e420). accessor_conflict_export2_test: Crash accessor_conflict_export_test: Crash deep_nesting1_negative_test: Crash deep_nesting2_negative_test: Crash

add_field_and_remove_subclass fails heap validation in 64-bit

1

``` FAILED: none-dartino_tests release_x64 dartino_tests/incremental/experimental/add_field_and_remove_subclass Expected: Pass Actual: Fail CommandOutput[dartino_test]: stdout: Running '/mnt/data/b/build/slave/dartino-linux-release-x86/build/sdk/out/ReleaseX64/dartino-vm -Xvalidate-heaps' Test 'add_field_and_remove_subclass' Program version 1 #add_field_and_remove_subclass: ==> main.dart invokeMain(arguments); 1: entry @callMain(new _Arguments()) Program version 2...

Incorrect position of type arguments error on map and list literals

2

``` $ cat t.dart main() { print([ 1, 2, 3, ]); } $ ./fasta compile t.dart t.dart:2:33: Warning: Too many type arguments on List literal. print([ ^ ``` The location...