Andy Lester comments

Results 497 comments of


                                            Andy Lester

RequireFinalReturn, no return after if statement

I'd like to leave this open, because it is indeed a problem, even though nobody has had time to address it.

Request: Integration of rules' POD into SonarQube plugin

If I'm understanding correctly, you're wanting to generate the HTML that comes from the Perl::Critic POD into another project? Personally, I can't imagine it would be a problem, but I'm...

Please support localized variants of PBP

If someone comes up with a plan about how to implement this, and has the time to do it, we can entertain the idea. Right now, it looks like there...

Suggested policy: duplicate use and require

What problems would this be solving? If I have use Foo; .... require Foo; is there a problem? The `require` is unnecessary, certainly. Anything else?

Suggested policy: duplicate use and require

I'm certainly not against identifying unnecessary code. Just clarifying that there wasn't some other problem this could introduce. I'm even more interested in the scenario of two different `use`s with...

Consolidate separate regular expressions

Thanks for this.

t/12_policy_listing.t and t/13_bundled_policies.t may fail

Any idea why? Is it because `Plicease::ProhibitLeadingZeros` duplicates a core policy?

t/12_policy_listing.t and t/13_bundled_policies.t may fail

I think it's OK. I think ::Freenode replicates policy names, too. I think.

ValuesAndExpressions::ProhibitCommaSeparatedStatements reports argument list inside formats

> any news? Reported 13 months ago, and still valid Someone needs to have the knowledge and time to fix it.

Integer with leading zeros on mode change

I don't see how Perl::Critic could know that you're changing mode. It handles `chmod` but it can't know how any given number is being used.