Andy Lester comments

Results 496 comments of


                                            Andy Lester

no highlighting when searching with regrex

I don't think that's going to work because vim + ack's regexes are so very different.

Automatically escape special chars

Yes, you're correct. `-Q` will turn off all metacharacters, and `--` tells ack that it is at the end of the command line options.

Perl::Critic::Utils should be moved to something like PPI::Helpers

> release a fork of the current functions in Perl::Critic::Utils directly; I'm not sure what you mean by this. You'd release a distro that was just Perl::Critic::Utils?

Perl::Critic::Utils should be moved to something like PPI::Helpers

So long as you wouldn't expect Perl::Critic to use PPIx::Stopgap, I don't see that it would affect Perl::Critic. Eventually we'd want to use the forked functions once they got a...

Perl::Critic::Utils should be moved to something like PPI::Helpers

That seems fine to me. I just don't want to convert to using the utilities PPIx::Stopgap and then again when they make their final home in PPI. If you want...

Minimize module loading

I don't have any memory usage penalty numbers, because I wasn't even at that point yet. So far, it's just a "Hmm, why is that here?" Every so often I...

Headings don't show up with --passthru

Does using `--passthru` even make sense if we're not reading from STDIN?

Document Dumper methods available for use

search by file's extension

If you were calling ack from the command line, you'd say "ack whatever --rb --js --css". But I don't know about in ackmate.

`git grep -o` shows only the part of a line that matched

Thanks for this. There's lot a lot that is out of date on that chart, but this is a good step in the right direction.