Andy Lester comments

Results 496 comments of


                                            Andy Lester

Dockerize

Done. Thank you. See c9f4d5fd

Consider dropping "use base" suggestion from Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA in favor of "use parent"

Perl::Critic now uses `parent` everywhere. The policy now recommends `parent` instead of `base`. #987

Add 'allow' parameter to Subroutines::ProhibitBuiltinHomonyms

Thanks for this. I had to make the changes manually because of the conflicts. This will go in the next release. Sorry it took so long to apply. 795a627bca27aa8b296d8b10523d482895dd932d

InputOutput::ProhibitBarewordFileHandle dies on `open(CHECK, '/foo');`

Fixed and merged. Thanks @trwyant. 16fe3c7f

ProhibitStringyEval: allow package declaration when allow_includes = true

Merged. Thank you. 0163492923fa5c56423591d18ac14762297f0d1c 3980fc699cf56603c8cce72ff7797e82414e0760

Update ProhibitReusedNames to cache canonical vars

Oh, the merge conflicts. I'll have to work on this. Or if someone else wants to, that's fine, too.

Stop improper violation for lexical subroutines in Subroutines::ProhibitBuiltinHomonyms

What do we need to do to get this something I can merge? I know we'll need to remove the PPI workarounds. How does URI::cpan fit in to this?

Stop improper violation for lexical subroutines in Subroutines::ProhibitBuiltinHomonyms

This tested just fine on a test branch with no conflicts, so I've squashed and merged it here. Thank you.

Stop improper violation for lexical subroutines in Subroutines::ProhibitBuiltinHomonyms

All merged and ready for next release: 0edb07d8

Subroutine signatures recognized as prototypes

Anyone's disappointment in the tool or the process or the team working on it is not relevant to this ticket. Please drop it. The only thing that needs to be...