Andy Lester comments

Results 496 comments of


                                            Andy Lester

Ack hangs when used in conjunction with ssh in a single line command

> The option would be clearer to me as --[no]stdin. I've thought about that, too. Note that there have been problems with expectations of ack's handling of stdin since the...

Ack hangs when used in conjunction with ssh in a single line command

Indeed, you can't read from both STDIN and a regular file.

Ack hangs when used in conjunction with ssh in a single line command

I'm seriously considering removing the implicit "figure out if ack is being a filter" or not. See the ticket referenced just above in the ack3 queue.

Add a timer so we can see what takes a long time to search

I think this will help in diagnosing beyondgrep/ack2#236

Add new type: QML

Do you have a custom file type set up in your .ackrc? What is it? How long have you been using it? Is your use case to only search QML...

Add $_ and $. to list of variables you can use with --output

Ultimately, I think we should whitelist the `$` vars that we allow to be used in `--output`. I see no reason to allow `$]` or similar in output.

Add $_ and $. to list of variables you can use with --output

I think that we want to not do eval on --output, and instead do the substitutions ourselves.

Add $_ and $. to list of variables you can use with --output

Shoot, I'd forgotten about those. Mark Fowler has a bunch of --output magic here, too: http://www.perladvent.org/2014/2014-12-21.html ``` ack --output='$&: @{[ eval "use LWP::Simple; 1" && length LWP::Simple::get($&) ]} bytes' \...

Add $_ and $. to list of variables you can use with --output

But is that capability overdoing ack's capabilities? That could just have easily been done like so: ``` ack 'https?://\S+' --output='$&' | perl -MLWP::Simple -e'......' ```

Add $_ and $. to list of variables you can use with --output

I'm OK with breaking backward compatability in the name of locking down the overly-wide-open door of `eval`.