Jake Hoban
Jake Hoban
I have this too. Most notes import but quite a few fail. Failed: "" because TypeError: Cannot read properties of undefined (reading 'split') - repeated multiple times. No images involved...
I'm keen to see this feature too, but please let's be adults and keep conversation here respectful. Everyone is doing the best they can with imperfect tools in an imperfect...
@sfirke as per Slack discussion, thank you!
@justinpark I think this is pending your review - please let me know if anything needed from my side, with apologies for any oversight as I'm new to the process.
Fixed a typo in the test script
In the last run the code seemed to be working but test was expecting wrong thing... maybe this time :)
@sfirke sorry for slow response, just did a commit, is it too late for the release (assuming it works this time)?
Seems to be failing because of "E501 Line too long" in superset/utils/date_parser.py, although that file is full of `# pylint: disable=line-too-long,useless-suppression` There was an actual code error which I've fixed.
Yes, I had a syntax error (== instead of ===) which would have meant the code didn't execute causing any functional test to fail. I've fixed that now. If it...
Oops, thought I'd done a push - just done now.