Jingchao (Perry) Zhong

Results 10 comments of Jingchao (Perry) Zhong

> The tool fails to detect passwords unless they are enclosed in quotes. For example: > - `password=hjsadni221` is not detected, > - but `password="ansdna"` is detected. Hi @geekNero, @howard-adam,...

> @perryzjc hi again 😄 could you please merge master into your branch? @lorenzodb1 hi, I've merged the latest updates from the master branch into my feature branch as requested....

> @perryzjc looks like there's some pre-commit checks failing, please take a look @lorenzodb1 Thanks for letting me know. I've resolved the issues and all checks are now passing in...

> Do you think we could add a way for someone to specify a domain so that this plugin flags only emails from that domain? @lorenzodb1 What if we add...

Encountered the same issue. I used my customized plugins to generate a baseline file, ```bash detect-secrets scan ./ \ --all-files \ --baseline .detect-secrets/.secrets.baseline \ --exclude-files '^\.git(/.*)?$' \ --exclude-files '^\.detect-secrets(/.*)?$' \...

> FYI @perryzjc. @riverma Thank you for bringing this to my attention. I will investigate the issue and work on addressing it.

I find it interesting that `*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOG STASH ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*` is a valid format for a filename or folder on a Mac. ![image](https://github.com/NASA-AMMOS/slim/assets/92573736/e1494989-cee4-476b-b572-4737679876d4) Due to this, I am considering reducing the...

> `*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOG STASH ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*` is a valid format for a filename or folder on a Mac. Hi @riverma, my point was that since it's possible to use this format...

> > `*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ LOG STASH ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*` is a valid format for a filename or folder on a Mac. > > Hi @riverma, my point was that since it's possible to...

> If the second layer still flags the strings as valid file paths, then I suggest we either: > > * Blacklist common comment blocks in languages like `/*...*/`, `//...