rsql-jpa-specification icon indicating copy to clipboard operation
rsql-jpa-specification copied to clipboard

Spring Boot starters should reuse ConversionService

Open manosbatsis opened this issue 2 years ago • 3 comments

Instead of "manually" trying to convert from String to a target type, the library should reuse converters and application settings via an @Autowired ConversionService

manosbatsis avatar Jun 01 '22 00:06 manosbatsis

Which part do you mean? Custom value converter?

perplexhub avatar Aug 03 '22 17:08 perplexhub

Seems to me that, with the Spring Boot starter, RSQLVisitorBase does not use a ConversionService from the Spring context and thus does not utilize build-in or custom converters available.

manosbatsis avatar Aug 09 '22 22:08 manosbatsis

As Object to Object conversion was removed from conversionService, I think we better not to remove it from the Spring one.

Custom converters can be add via RSQLJPASupport.addConverter().

See example here

perplexhub avatar Aug 10 '22 11:08 perplexhub