Jose

Provide SNI hostname to the server certificate selection callback

1

Should we also provide the SNI hostname if it's available for these? _Originally posted by @externl in https://github.com/zeroc-ice/ice/pull/2063#discussion_r1581412901_

I know you didn't change this, but I don't think this const cast is necessary. _Originally posted by @externl in https://github.com/zeroc-ice/ice/pull/2063#discussion_r1581435704_

SChannel host name verification

1

The Schannel implementation of Ice SSL transport calls [`IceSSL::SSLEngine::verifyPeerCertName`](https://github.com/zeroc-ice/ice/blob/889764507514e17a69113d45d6f13f89a70dffb5/cpp/src/IceSSL/SSLEngine.cpp#L73) to verify the peer certificate name. We should switch to using the [`CertVerifyCertificateChainPolicy`](https://learn.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-certverifycertificatechainpolicy) method provided by Schannel.

With SCHannel and OpenSSL we allow specifying multiple certificate files. The intention was to allow to load one RSA certificate and one DSA certificate, DSA certificates are not recommended in...

``` -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -c ../cpp/src/Slice/Grammar.cpp -o modules/IcePy/build/arm- linux-gnueabihf/shared/pic/Grammar.o cc1plus: error: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ [-Werror] cc1plus: error: ‘-Werror=’ argument ``` See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067911

Replace PropertyArray with std::array

1

In PropertyNames.h we define `PropertyArray`: ``` struct PropertyArray { const Property* properties; const int length; PropertyArray(const Property* p, size_t len) : properties(p), length(static_cast(len)) {} }; ``` I think we should...

_Originally posted by @bernardnormier in https://github.com/zeroc-ice/ice/pull/1978#discussion_r1535629907_

Currently it is possible to create an adapter that has endpoints and a router, but in practice should be one or the other. For 3.8 we want to make this...

https://github.com/zeroc-ice/ice/blob/5df33ffae93532e539c81dd6ead00059a75bd572/cpp/src/Ice/Network.h#L46-L50 This macro allows building Ice on Windows without IOCP, but we never do and we no longer test this code. Is a leftover from earlier releases and we should...

I saw this when running with Python debug build on Windows ``` *** [30/35] Running python/Ice/servantLocator tests *** [ running client/server test - 03/16/24 18:27:24 ] - Config: ssl,Debug,x64 testing...