Jose

Use JS modules as default module mapping

1

For 3.8 we should consider get rid of our module mapping and go with JS native modules as default. We should check if it is also possible to get rid...

Don't use a mutex for computing Reference hash

1

I don't think we should use any mutex in this code. Either the hash is very cheap to compute and we compute it each time. Or it's somewhat expensive to...

We define `ICE_UNALIGNED` when unaligned memory access is supported https://github.com/zeroc-ice/ice/blob/d25deea3be3c813ea43ed5ceeac794ba5dbc2f89/cpp/src/Ice/InputStream.cpp#L24C9-L28 We should review if ARM64 can be added here, we should also a comment to explain what this define is...

The removal of local Slice, copied the generated files into the source tree. The Python install doesn't install these files.

2024-01-09T22:41:30.4098479Z process D:\a\ice\ice\cpp\test\IceGrid\replication\msbuild\client\x64\Cpp11-Release\client.exe --Ice.Default.Host=127.0.0.1 --Ice.Warn.Connections=1 --Ice.Default.Protocol=ssl --Ice.IPv6=0 --Ice.Admin.Endpoints="tcp -h 127.0.0.1" --Ice.Admin.InstanceName=Client --IceMX.Metrics.Debug.GroupBy=id --IceMX.Metrics.Parent.GroupBy=parent --IceMX.Metrics.All.GroupBy=none --Ice.Plugin.IceSSL=IceSSL:createIceSSL --IceSSL.*** --IceSSL.DefaultDir=D:\a\ice\ice\certs --IceSSL.CAs=cacert.pem --IceSSL.CertFile=client.p12 --Ice.NullHandleAbort=1 --Ice.PrintStackTraces=1 --Ice.Default.Locator="TestIceGrid/Locator:default -p 12030" --ServerDir=msbuild\server\x64\Cpp11-Release --Ice.Trace.Network=2 --Ice.Trace.Retry=1 --Ice.Trace.Protocol=1 --Ice.ACM.Client.Heartbeat=2 --Ice.LogFile=D:\a\ice\ice\cpp\test\IceGrid\replication\client-010924-2206.log...

Escape sequences in doc comments

1

``` // Slice const string ss3 = "\\\\U\\u\\"; /* \\U\u\ */ const string ss4 = "\\\u0041\\"; /* \A\ */ const string ss5 = "\\u0041\\"; /* \u0041\ */ ``` This results...

See comment in https://github.com/zeroc-ice/ice/pull/1590#discussion_r1430549905

Const correctness of dispatch code

2

C++ 11 generated code for a dispatch looks like ``` /// \cond INTERNAL bool PollingChat::PollingChatSession::_iceD_getUpdates(::IceInternal::Incoming& inS, const ::Ice::Current& current) { _iceCheckMode(::Ice::OperationMode::Normal, current.mode); inS.readEmptyParams(); ChatRoomEventSeq ret = this->getUpdates(current); auto ostr =...

The `CustomLambdaOutgoing` constructor uses `std::move` to assign the sent callback from the corresponding parameter, but the caller in the generated code is not passing a lreference. There is a missing...

The generated C++ one-shoot constructor for a class looks like this: ``` MessageEvent( long long int timestamp, const ::std::string& name, const ::std::string& message) : Ice::ValueHelper(timestamp, name), message(message) { } ```...