penumbra

penumbra copied to clipboard

pcli: `validator-governance-subkey` subcommand is in the wrong place

3

**Describe the bug** Running `pcli init --help` describes a `validator-governance-subkey` command that's only relevant for validators. We already have a place for commands that are only relevant for validators, namely...

hdevalence

We have a streaming RPC that let us query multiple auction state at once: ```protobuf rpc AuctionStateByIds(AuctionStateByIdsRequest) returns (stream AuctionStateByIdsResponse); ``` At some point, it would be good to implement...

erwanor

Add alt fee token support to `pcli`

1

As described in #4320, > Change the pcli tx command so that the existing `--fee-tier` and a new `--fee-token` parameters move to `pcli tx`, and apply to all subcommands (i.e.,...

hdevalence

Audit use of panicky-macros

3

In #4444 @cratelyn noted that the use of the `unimplemented!()` macro in RPCs can allow a malicious client to crash the node software. I performed a brief search through the...

zbuc

We have had two cases where duplicate note commitments caused crashes / hangs in the view server, in #3945 and #1507. This was last resolved in #4423. These bugs had...

redshiftzero

In #4498, we modified the swap encryption and left in the legacy decryption path such that testnet users in an upgrade would be able to decrypt old swap ciphertexts and...

redshiftzero

Currently we use `Zeroize` only for the secret types in `decaf377-ka` (for no specific reason): https://github.com/penumbra-zone/penumbra/blob/main/crates/crypto/decaf377-ka/src/lib.rs#L17 It would be good to do a pass through the entire codebase and use...

redshiftzero

`pcli query governance list-proposals` is hard to read

2

**Describe the bug** ``` $ pcli query governance list-proposals -i #0 ProposalState { state: Some(Finished(Finished { outcome: Some(ProposalOutcome { outcome: Some(Passed(Passed)) }) })) } lower proposal voting duration to 4h...

plaidfinch

Add histogram metrics for end-to-end CheckTx latency

1

**Is your feature request related to a problem? Please describe.** It would be useful to know how long CheckTx takes, and report this info with Grafana. **Describe the solution you'd...

hdevalence

Add protos for TCT crate structs

2

The TCT crate has a few important structs that do not have protobuf equivalents. The one the web repo uses the most is `Updates` and all of its fields: https://github.com/penumbra-zone/penumbra/blob/6897901b37f5c72d4b5c593167f0e0b933dd2eb5/crates/crypto/tct/src/storage.rs#L279-L290...

grod220