Petar Penović

Results 23 comments of Petar Penović

If you need this feature ASAP there is a draft PR linked to this issue that can help you get unblocked. If you switch to the corresponding branch and execute...

The duplication for the `@noble` libraries occurred because they are used both directly and as sub-dependencies for one of the `@scure` libraries where they are limited to only patch version...

`starknet.js` doesn't do anything fancy with the error response it just passes along the top level code and message. The reported issue arose because the error message that was once...

> @penovicp would it make sense to return the whole error object to the user? It would help a lot with debugging In the latest pre-release the underlying error response...

I opened [PR#1 ](https://github.com/PhilippeR26/starknet.js/pull/1)with some modifications. It boils down to two main alterations: changed the names so it is more apparent that the new entities are related to each other;...

I would suggest adding two more rules to reduce potential ambiguity some more: - Name can't be enclosed in whitespace characters - Name can't contain the comma (,) character (this...

For the whitespace rule I would assume just using the word "whitespace" and relying on the `\s` RegEx could be sufficient. I would hope that it's mostly standardized between different...

> > #1039 - Don't change implementation, clarify the SNIP > > #1342 - Don't change implementation, clarify the snip, have a new revision if the change is necessary >...

Considering this issue and the faulty enum encoding noted within #1292, the option of introducing a new revision to the SNIP-12 spec was brought up as a possible solution. The...

This is an overview of the mentioned discrepancies with the encoding: - `shortstring` - numerical string encoding is done the "starknet.js felt way" (`"2"` as `0x2`) and not the "cairo...