Jerry Tsui

Results 18 comments of Jerry Tsui

+1 to this - only calling `toast.remove()` and `toast.remove(id)` is working for me as well -- I'm using `toast()` instead of `toast.custom()` though

> @peniqliotuv we don't need to set hash for LSI index, keep it simple like that: lsi1: { sort: 'lsi1sk', type: 'local' } If it's not required, should it be...

+1 - this is especially problematic when we have resolvers that explicitly invoke another resolver and expect the result from that resolver to be typed - leading to a lot...

@patrick91 @BryceBeagle Here's a case I added to `tests/mypy/test_fields.yml`: ``` - case: test_type_annotation_field main: | import strawberry @strawberry.type class User: @strawberry.field def age(self) -> int: return 42 reveal_type(User().age()) out: |...

@patrick91 does the refactor of `StrawberryField` version 0.53.0 solve this?

Thanks for getting back to me @patrick91 ! Would you recommend waiting until python/mypy#9925 is merged (i.e: is Strawberry planning on taking the mypy plugin approach or the strawberry field...

> > Thanks for getting back to me @patrick91 ! Would you recommend waiting until [python/mypy#9925](https://github.com/python/mypy/pull/9925) is merged (i.e: is Strawberry planning on taking the mypy plugin approach or the...

> > This issue been added to the v1 milestones, but what I'm having trouble parsing the following from the discussion: > > > > * What was the conclusion...

Hey, circling back and was wondering if this is going to be on the roadmap any time soon!