Pekka Enberg
Pekka Enberg
@diegoreis42 This is working now, right?
Rollback was added in a48198ec607ceaccba7c715e390b3da42293147d
This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.
@pax-k I am actively working with folks to iron out some bugs and then get this merged.
This work has been merged as part of the following PRs: https://github.com/tursodatabase/libsql/pull/1531 https://github.com/tursodatabase/libsql/pull/1551 https://github.com/tursodatabase/libsql/pull/1557 https://github.com/tursodatabase/libsql/pull/1560 Therefore, closing this.
@travenin Yes, we should just fix Limbo to use same floating point format as SQLite. Probably _after_ @PThorpe92's https://github.com/tursodatabase/limbo/pull/462 lands in main, though :)
Unfortunately moving this to 0.3 milestone because we just ran out of time to get this for 0.2
I wonder where we use more than 1 MB of stack, though?
@gkmngrgn How did you fix the files? I am curious to understand if we fixed "pylimbo" now in all the relevant places or if the wrong name will pop up...
@dkaluza We _are_ actually now pulling the system-wide `sqlite3.h`, but perhaps we should indeed fix it to grab the one generated by Limbo.