Pekka Enberg comments

Results 454 comments of


                                            Pekka Enberg

RFC: core: 1st party sql parser using winnow combinators

@jussisaurio Rolling out a parser by hand is going to be very hard to make compatible with SQLite. If you want more control over AST generation, a better path is...

RFC: core: 1st party sql parser using winnow combinators

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

Create common crate and move value and affinity code there

Hey @pedrocarlo, I don't fully understand the refactoring you're trying to do here, but a "common" *crate* makes no sense because it's not something anyone actually consumes. Remember, every crate...

Create common crate and move value and affinity code there

Hey @pedrocarlo, I don't disagree with making `core` slimmer, but the name `common` already is a giveaway of lack of any architecture here. In fact, if you'd call it `random`...

Prepared stmt bugs

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

Prepared stmt bugs

This pull request has been closed due to inactivity. Please feel free to reopen it if you have further updates.

Fix ptrmap data corruption with pre-initialize autovacuum database

Hey @ddwalias! Good catch! I am disabling autovacuum by default in https://github.com/tursodatabase/turso/pull/3899. Let's have other people review this PR too, but assuming the improvement is good, this is eligible for...

Limbo does not enforce primary key uniqueness on PKs that are not rowid aliases

@el-yawd Indeed, thanks!

Preserve foreign key clauses when adding columns via ALTER TABLE

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

Validate page 1 header

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.