Pekka Enberg

Results 454 comments of Pekka Enberg

I don't know if we improved on quality or did something, but CI is no longer failing randomly because of fuzzers. Closing

@LucioFranco What happens if the metadata file is corrupted? The code should recover from that by trying to push the whole log.

@LucioFranco I corrupted the info file as follows: ``` {"hash":3168545583"version":0,"durable_frame_num":120,"generation":1} ``` and now I see this error: ``` Running `/Users/penberg/src/tursodatabase/libsql/target/debug/examples/offline_writes` thread 'main' panicked at /Users/penberg/src/tursodatabase/libsql/libsql/src/sync.rs:161:78: called `Result::unwrap()` on an `Err`...

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

This pull request has been closed due to inactivity. Please feel free to reopen it if you have further updates.

Hey @enki! The API looks great. Let's get the build errors fixed and happy to merge

There's a merge conflict on `package.json` now that I merged bunch of other PRs.

I am unfortunately not able to reproduce here. That error code 21 is `SQLITE_MISUSE`, which suggests validation at the C API level failed, not something that comes from the internals....

@LucioFranco Nailed down the problem to sqlite3mc. If I enable `encryption` feature, I can now reproduce: ``` penberg@vonneumann libsql % cargo run --features encryption --example offline_writes Finished `dev` profile [unoptimized...