Thomas Pelletier

Results 64 comments of Thomas Pelletier

@Felixoid @stingalleman Pull requests #803 and #798 have been merged. Unless I missed something those two should fix both the extra new lines and the incorrect propagation of omitempty. Let...

Implemented a specialized generator that works for any slice type. Though this works well on benchmarks that use multiple slice types (`ReferenceFile/struct`), there is a bit of overhead for the...

``` name old time/op new time/op delta UnmarshalDataset/config-2 24.3ms ± 1% 24.7ms ± 0% +1.66% (p=0.016 n=5+4) UnmarshalDataset/canada-2 85.8ms ± 0% 62.5ms ± 1% -27.20% (p=0.008 n=5+5) UnmarshalDataset/citm_catalog-2 27.2ms ±...

Thank you for the feedback! I wonder if we could use Go functions to represent the multiple versions of the program. For example: ```go func main() { const n =...

Sounds good to me. I'll submit a new PR that adds `Ifdef` and friends. I'm in favor of a package named `pp`, `preproc`, or `preprocessor` to avoid typing non-`a-zA-Z0-9` package...

I think `IncludeHeader` makes the most sense to me. It does what it says in the name, as opposed to get an error at first run. If people end up...

@shizhx I don't think anyone is working on this at the moment.

@Felixoid no worries! Thank you for letting me know. I went ahead and filed a new issue https://github.com/pelletier/go-toml/issues/888

Good insight on #858: maybe we should consider passing the type of the target to provide a more accurate error.

@mmcloughlin As I'm going to be reworking #406, do you have any opinion on this change? https://github.com/mmcloughlin/avo/pull/407/commits/e86a5cccf71f7e045286d6b8ca0d8f5f482c211a