Thomas Pelletier

Results 19 comments of Thomas Pelletier

This issue comes from @chriso saying there may be dependencies being created between YMM registers that could be avoiding by manually picking registers: https://github.com/segmentio/asm/pull/58#discussion_r778501347. I haven't looked closely at what...

Thanks for the report! Sounds a like a good time to start sprinkling more of https://github.com/pelletier/go-toml/blob/7baa23f493a82b3f24f4dada5d0b02d17fbde175/unmarshaler.go#L151 to return more specific errors.

Thanks for the patch! I'd love for go-toml to support tinygo. I'll try to see if I can set up CI to test against it too.

@josegonzalez any chance we could get some feedback on this please? :)

Definitely looks like a bug. Thanks! I'll take a look.

This issue should be fixed as of https://github.com/pelletier/go-toml/commit/7baa23f493a82b3f24f4dada5d0b02d17fbde175. With this example you should see an error like: ``` toml: cannot decode array table into a map[string]int ``` Feel free to...

Looks like that's still not great in v2: https://play.golang.org/p/9xauDfRSQI7 ``` 1| host = builddb | ~~~~~~~ incomplete number 1| persistent_peers = [email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656 | ~ expected newline but got U+0037 '7'...

Neat idea! Do you think there would be any functional difference with json.RawMessage?

Thanks for the bug report! > It creates empty lines at the place records should be You're right, those extra new lines shouldn't be emitted. > For the slices of...

@Felixoid for the indentation issue, you also need to `.SetIndentTables(true)` for the encoder to indent tables (and use whatever indentation string was provided to `SetIndentSymbol`). I started working on those...