Robert Pająk comments

Results 948 comments of


                                            Robert Pająk

Prometheus exporter: omit empty otel_scope_info and otel_target_info metrics

Changed to draft as the build is failing.

Add OTEL_SERVICE_VERSION

Related to https://github.com/open-telemetry/opentelemetry-specification/issues/3025 We could allow setting resource attributes usingfollowing pattern `OTEL_RESOURCE_[KEY]=[value]` where the "KEY" would have to be transformed by making it lowercase and replacing `_` with `.`. A...

fix callback err not return

Thank you for the PR. Can you add a changelog entry and add a unit tests to cover these cases?

fix callback err not return

@NameHaibinZhang, are you able to work on this PR?

chore(ci): add semconv-update workflow for automatic updates

Thank you for your PR. It seems that @MrAlias is working on a new way to generate semconv packages (see: https://github.com/open-telemetry/opentelemetry-go/pull/6683).

otelconf: Increased test coverage for Prometheus-related code

@sonalgaud12, are you able to address the comments?

otelconf: Increased test coverage for Prometheus-related code

@sonalgaud12, are you able to address @XSAM's comments?

otelconf: add env var substitution in ParseYAML

> @pellared would love a review from you as you've requested changes which I made I will do my best to review this week. Thanks a lot.

otelconf: add env var substitution in ParseYAML

https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6215#discussion_r2403289205 is not addressed. Other than that, LGTM

otelconf: add env var substitution in ParseYAML

@open-telemetry/go-approvers, would be nice to have more reviews. Otherwise, we can merge this on Thursday or Friday.