ぺこ

Results 7 comments of ぺこ

fix: panic, unwrap to unwrap_or

@ry I will add a test to `integration_test` in `testing/lib.rs`. Test that there is no panic when executing code like issue.

fix: panic, unwrap to unwrap_or

@ry I added an integration test. I don't use `unwrap_or_else()`, is that a problem?

fix: panic, unwrap to unwrap_or

@bartlomieju I’m sorry. I’ll be careful next time.

fix: panic, unwrap to unwrap_or

Thanks for the suggestion. I may not understand it yet, but I confirmed that if I handle the `push()` pseudo, I won't get the error. I'll do some more testing....

fix: panic, unwrap to unwrap_or

Confirmed that all tests pass. If you see a problem, point it out. ``` primordials.ArrayPrototypePush = (thisArray, ...variableArgs) => { const args = [...variableArgs]; for (let i = 0; i...

Deno has panicked when prototype.__defineSetter__ used on built-in objects

@bartlomieju Will deprecated features be implemented in Deno? I would like to try if only to fix Panic.

Deno has panicked when prototype.__defineSetter__ used on built-in objects

@bartlomieju Thanks for the reply, I'll start working on a fix. `Object.prototype.__defineSetter__` is not defined in type and I couldn't find the implementation. So I mistakenly thought it was unimplemented.