Petr Hála

Results 191 comments of Petr Hála

* [Docker] We could also add docker support for both client and server (Maybe separate issue?). * [WINDOWS] https://stackoverflow.com/questions/49651902/how-to-get-the-jre-to-bundle-with-launch4j Maybe this could solve the problem with launch4j. * [MacOS] I...

For the version consistency, I think we could migrate to version format like 2.1.0.0, which should be usable in all settings.

We can do this manually before release with `mvn versions:set -DnewVersion=2.1.0.0` which actually sets it for all submodules as well. I will create PR which changes current master to this...

> I agree, Homebrew makes it very easy to install Java 8. However bundling the JRE is extremely easy (download JRE directory to a temporary directory and adding a single...

One additional thing we could do is to create pre-release (2.1.0.0-BETA) to test if the release action works, to actually test it and to compare with this updated one.

Sure we can try that. https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#environment-files

We can use it at least temporarily, but it is deprecated and probably will be removed in the future. I suggest we leave the issue open (or create a new...

Now the questions is how we want to do it, creating Dockerfile is trivial (except for potential problems with GUI in containers), but the problematic part is the publishing. *...

That is the question, I am not sure about distribution rights and code rights, if we don't want to publish it tho, there is not way of even implementing it.

On the other hand, we already distribute binaries in form of .jar and such on GitHub so docker hub isn't that much different from what we are already doing.