John Huang comments

Results 80 comments of


                                            John Huang

[Improvement] Refactor the writer code with builder pattern

Hi, @zuston , I am trying to figure out your reason for builder mode on shuffle reader/writer. Any hints or guidance from your side? For example, Should I abandon all...

REQUEST: New membership for @pegasas

> > I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application > > Hey @pegasas, ping me and @srikanthccv on CNCF...

istio.io blog should allow simple labels to category blogs and even incorporate good istio blogs from other sites

Consider enrich ambient architecture page

Hi, @linsun , I created a PR to fix this issue. I mainly enrich the `Differences from sidecar architecture` part, I think this is the major architecture thinking of ambient...

Using the Helm SDK when no kubeconfig is available

hi, @bacongobbler, I have a plan to integrate client-go clientcmd client config into this, I have tested it work on azure kubernetes cluster. ``` type RESTClientGetter struct { Namespace string...

How use ETCD as externalRegistry in k8s

It seems related to https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/README.md?plain=1#L5-L29, I've create PR trying to add link into docs.

How use ETCD as externalRegistry in k8s

kick

[Improvement][Spark] Support Local Spark Cluster

attach test pics: ![image](https://github.com/apache/dolphinscheduler/assets/13224827/ae1e3474-bb2a-45b7-86b6-6963e3cfc9ab) ![image](https://github.com/apache/dolphinscheduler/assets/13224827/71068ac1-3dc8-4fcd-abad-e1f7e3a553a5) ![image](https://github.com/apache/dolphinscheduler/assets/13224827/5340fb15-2a9f-4ed4-9970-227bcf314ba1) ![image](https://github.com/apache/dolphinscheduler/assets/13224827/9156d2f2-5193-4793-b905-caa861512cef)

[Improvement][Spark] Support Local Spark Cluster

> > attach test pics: ![image](https://private-user-images.githubusercontent.com/13224827/309485479-ae1e3474-bb2a-45b7-86b6-6963e3cfc9ab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk1MjU1MzAsIm5iZiI6MTcwOTUyNTIzMCwicGF0aCI6Ii8xMzIyNDgyNy8zMDk0ODU0NzktYWUxZTM0NzQtYmIyYS00NWI3LTg2YjYtNjk2M2UzY2ZjOWFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA0VDA0MDcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4MDFjZTI3OWVhMDZjOTIzNWM4M2U5NTBhOTlmMWI0YzFhMGMwMWE5M2ZiZDE3ZWQ1NTA2ZWNiM2RkNTZkZTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.icqtVm_lInEN0HNPDPoGnsx2Al2luhB2vT1XWkIu34Y) ![image](https://private-user-images.githubusercontent.com/13224827/309485544-71068ac1-3dc8-4fcd-abad-e1f7e3a553a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk1MjU1MzAsIm5iZiI6MTcwOTUyNTIzMCwicGF0aCI6Ii8xMzIyNDgyNy8zMDk0ODU1NDQtNzEwNjhhYzEtM2RjOC00ZmNkLWFiYWQtZTFmN2UzYTU1M2E1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA0VDA0MDcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM5Y2FlN2Q5YTdiNzhhNWYyNWZhZTkyMjI4N2NjNjMzZjIxNzA1ZmUzODcyMzE4MWQ0OWVkZjdlODdjMTE2ZjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6hjA7fXueGsedRCutp0iUovwMkyU7LRtj8TWFHmDHmg) ![image](https://private-user-images.githubusercontent.com/13224827/309485657-5340fb15-2a9f-4ed4-9970-227bcf314ba1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk1MjU1MzAsIm5iZiI6MTcwOTUyNTIzMCwicGF0aCI6Ii8xMzIyNDgyNy8zMDk0ODU2NTctNTM0MGZiMTUtMmE5Zi00ZWQ0LTk5NzAtMjI3YmNmMzE0YmExLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA0VDA0MDcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1YWZjNjkzOGZmMGExNDc2MTQ4ZmU2NTNhMTIyMWNiMWExMTJkMjY5NDY0NDc2NGM0ZmY4ZDY4ZTFjMDRmMDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4zUNK5PU7sH0UHJ8ty4Aria9D-MRP16b2PhA0JWMnQg) ![image](https://private-user-images.githubusercontent.com/13224827/309485788-9156d2f2-5193-4793-b905-caa861512cef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk1MjU1MzAsIm5iZiI6MTcwOTUyNTIzMCwicGF0aCI6Ii8xMzIyNDgyNy8zMDk0ODU3ODgtOTE1NmQyZjItNTE5My00NzkzLWI5MDUtY2FhODYxNTEyY2VmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA0VDA0MDcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjOGQ2YzUwM2JlZDkyYWJiMjg5ZTNiYmVhMTI4MjY4MjBmNGM4NGQ4MTdhYzQ1Y2ZhZTcwOTM0NTk2N2ZjNzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ykSW5Cx38GDB_NLsE1Dvh9GXf5Xj6aRkWQhLpLQOzS8) > > @pegasas I don't think the `Master` on the ui is a required field, WDYT Done. I set required to...

[Improvement][Spark] Support Local Spark Cluster

> Please update the usage doc. updated.