Carter Carlson comments

Results 35 comments of


                                            Carter Carlson

Need correctly-upgradeable `contracts-upgradeable/metatx/ERC2771ContextUpgradeable.sol`.

Thanks for pointing out I was wrong in the ERC20/721 immutability. This short code solution is what I had in mind. So, in the end we're not truly dealing with...

Avoid compiling Test/Script toplevel contracts w/ zksolc

I don't think a flag would be a good idea because a lot of users will still hit the compile limit and if they're referring to the OG foundry docs...

`reentrantAware` modifier is not used.

Right, I understand that the storage is incremented. However, this storage is not checked or managed elsewhere so I do not understand the purpose of tracking the number of entrances.

fix: contract imports and license clarification

@bokkypoobah LGTM

feat(`forge flatten`): add dead code elimination

It's probably worth an additional flag as the automatic removal of unused imports may confuse some developers. I believe this would be a valuable feature as we'll see more utility...