Pedro M. Baeza

Please rebase and fix CI, and include #1244

Yes, it can be changed. The new icon seems a bit slim though. You can do it thicker.

I feel here there's a missing piece, as with this module, you can't import directly with `queue_job`. I also don't understand why going to such complex architecture, and more when...

Why the contract module doesn't serve? I agree is a bit more complicated, but developing an exact competing one inside OCA is not good. The path to follow is to...

They are not similar purposes. It's the SAME purpose and they look like more and more the same as those that have decided to go to the subscription path are...

Wow, Denis agreeing with me. Let's do a party! :stuck_out_tongue: The main issue with contract that always arises is that "it's too complicated". Part of the guilty for that is...

As commented directly, `product_contract` module already has some of the features you need to add to `subscription_oca`, so it's better to not duplicate also that part. Ripping out in new...

> Considering your mentions, I understand that we would have something like: > > * `contract` (the base module). > * `contract_renewal` or `contract_line_renewal` (just as initial names suggestions examples):...

Yes, there are two mixins created: - Over for joining the common things between templates and contracts themselves. - Other for joining recurrency things together (between header and lines) but...

I think `contract.contract` should inherit from `contract.template` and `contract.line` from `contract.template.line`. That way, we will reduce a lot the complexity a lot. About `contract.recurrency` mixins, maybe we can reduce both...