Pedro M. Baeza comments

Results 2428 comments of


                                            Pedro M. Baeza

Migration to version 18.0

I don't see it as an advantage, as there may be missing commits from the previous branch (17.0 in this case) in the moment of migrating a module (because between...

[18.0][MIG] l10n_es_aeat_mod349

Habría que incluir #4160

[18.0][MIG] l10n_es_aeat_mod349

Reemplazado por #4257 respetando atribución.

[16.0][IMP] sale_triple_discount: Improves perfs and consistency

I'm not using the module, but with current review status + coming from a trusted contributor, let's merge it: /ocabot merge patch

[15.0][FIX] fix unit tests on crm_salesperson_planner

There are still changes in the README

[15.0][FIX] fix unit tests on crm_salesperson_planner

I'm afraid there's still changes. Please check "Files changed" tab of the diff in your local

[16.0] improves loyalty_partner_applicability

Sorry, I haven't been able yet to check this. In principle, I agree it's weird to select the partner domain at a sublevel. Maybe a trick is to set it...

[16.0] improves loyalty_partner_applicability

I'm not sure I'm getting the problem depicted by @lmignon, but he is talking about coupons, not programs. Anyway, I would say once the coupon is issued, it has the...

[16.0] improves loyalty_partner_applicability

So is there a problem or not with this change?

[16.0] improves loyalty_partner_applicability

Then please suggest the needed changes.