Pedro M. Baeza

Starting with, 26 commits for an improvement seems insane. You should squash into logical feature blocks, not code changes commits. Then, you can ping the original authors/contributors of the module.

Thanks for the contribution. Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0. If the jump is between several versions, you have to modify the source branch in the...

You can squash all the migration commits into one. Now, functional/code reviewers should do the reviews. Both Stéphane and me were only reviewers about the form.

Cédric, you need to preserve commit history, as seen in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

/ocabot migration hr_attendance_hour_type_report

I mean this code for example: https://github.com/OCA/bank-payment/pull/1340/files#diff-bb6441f4ea06462fe1aae1f093f82c4e57460864b29b209676a6c7ce14e49ef9R156 It's avoiding to include the lines in the order.

OK, I based my review in https://github.com/OCA/bank-payment/pull/1177#issuecomment-2304668141. Let me check again.

@lmarion-source can you please check the latest comments?

Please cherry-pick #1112

/ocabot migration account_financial_report