Mark de Dios comments

Repositories
Issues
Comments

Results 4 comments of


                                            Mark de Dios

indentation on .catch

Hi, if this issue still needs to be addressed, I'm happy to work on it.

.throws with no message creates error with empty message

Hi, @mroderick, is this issue still open? I'd be happy to submit a PR with @ahmed1hsn's suggested changes if helpful.

.throws with no message creates error with empty message

Hi @fatso83, When I applied @ahmed1hsn's suggestion and ran `npm test`, I got one failing test ``` 1472 passing (2s) 11 pending 1 failing 1) sinonSpy.call call.toString includes exception: AssertionError:...

.throws with no message creates error with empty message

Very well. That sounds fine for now! Pushed the suggested change here: https://github.com/sinonjs/sinon/pull/2544/commits/2a83dfed01fab1a1d1de3dea1c1a99feff555b4c