Peter Martin

Results 43 comments of Peter Martin

I had some issues with git and the Joomla branches on my local system. So I checked out a crispy fresh 4.1-dev branch to redo my small patch. I didn't...

@richard67 @wilsonge I have changed my PR: - added a **new Field type** MenuItemByComponent to filter by menu item type (instead of component) Before the change the dropdown would be:...

@richard67 yes, I think so. Or do you have a suggestion for something better?

@brianteeman Yes, that's right. I wanted to filter on View and analyzed the #__menu table to see if it's easy to filter on views: it is not. The only field...

> > The banner component does not have a front-end view (only modules that display the banners). > Ah, sure, I should have known that. I would love to have...

I've fixed the issues in MenuItemByComponentField that @SharkyKZ mentioned.

Thank you both for your improvements @Quy + @SharkyKZ

@Quy @SharkyKZ @richard67 Do I need two new tests before getting it to RTC?

Thanks @brianteeman I've added the currentMenuType context to the component filter. Now the - Select Component - filter only shows the component views that are used in that specific menu....