Prashant

Results 18 comments of Prashant

> LGTM. I am just wondering if a standalone/teuthology test can be added to verify the logging levels. A standalone test appears to be the easiest. If it's time consuming...

Thanks @idryomov. I saw your review comments a bit later. I have added the relevant section in PendingReleaseNotes for removing mon_cluster_log_*_level options. Let me address your review comments for standalone...

> Apart from my comment related to include the refactoring commit, the changes LGTM. Thanks @sseshasa. I have added relevant refactoring commit id in the commit message. We probably need...

Closing this PR in favor of PR #47502.

> > The `make check` failure is legitimately due to the code change. > > ``` > > /home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/PGMap.cc:3348:32: error: unused variable 'sum' [-Werror,-Wunused-variable] > > const object_stat_sum_t& sum =...

Too many teuthology job failures due to this PR : https://pulpito.ceph.com/yuriw-2022-08-16_22:04:30-rados-wip-yuri5-testing-2022-08-16-0859-distro-default-smithi/

> Too many teuthology job failures due to this PR : https://pulpito.ceph.com/yuriw-2022-08-16_22:04:30-rados-wip-yuri5-testing-2022-08-16-0859-distro-default-smithi/ @neha-ojha What would be right approach to handle RADOS suite failures here ? Should we use `mon_warn_on_pool_no_app=false` in...

http://pulpito.front.sepia.ceph.com/pdhange-2022-09-08_00:09:39-rados-wip-pdhange-testing-distro-default-smithi/