Petr Drastil
Petr Drastil
@crenshaw-dev I'm probably not seeing why this could be breaking. Can you please explain? If you provide just single digit number it still works as before (currently: 90s = `time.ParseDuration`...
Thanks for the explanation - from documentation I've seen the `d` is not present because it could cause ambiguity. Ref: https://github.com/golang/go/issues/17767 Kinda elegant solution would be: - Regex capture of...
@crenshaw-dev Enhanced as proposed. As a bonus fractions now works as well like `1.5d`
@crenshaw-dev Hi, any chance you can take a look again?
@crenshaw-dev Hi - this is here for a long time - any chance you can look again?
I believe this might release to https://github.com/argoproj-labs/applicationset/issues/369 where we would like to use Git generator to fetch external yaml configuration from Git and put it into `helm.values` as a yaml...
@mkilchhofer Please take a look on another iteration and tell me WDYT. When you wanted to go with breaking change I've tried to consolidate parameters such as `tlsCerts` and `tlsCertsAnnotations`...
There is similar solution in [argo-events](https://github.com/argoproj/argo-helm/blob/768907653a45ab5c65eb21c9b435857351eaf8a9/charts/argo-events/templates/crds/eventbus-crd.yml#L8) or [argo-rollouts](https://github.com/argoproj/argo-helm/blob/768907653a45ab5c65eb21c9b435857351eaf8a9/charts/argo-rollouts/templates/crds/analysis-run-crd.yaml#L8) that allows to keep CRDs after uninstall. The real problem are configuration options `additionalProjects` or `additionalApplications` that would fail the installation if...
@yu-croco - If you are getting inspiration from Argo Events please note the `keep` option that is not in your PR. If you uninstall the chart CRDs will be also...
This will be available via `timeout.hard.reconciliation` parameter in https://github.com/argoproj/argo-helm/pull/1267 that exposes all currently known parameters / arguments. Linking just for reference so this is not merged into PR by mistake.