Pawan Dogra

Results 15 comments of Pawan Dogra

Hi, I tried to fix this in #293, but I think that this might lead to a decrease in performance as currently I am using ```into_vec``` to consume the ```Box```...

If this issue is still open, I'm definitely interested to work on this.

After discussing with @robertbastian we came up with an initial design but are kinda out of ideas. The idea was to have a trait `NicheBytes` which specified the bytes to...

`rust-semverver` errors out in some of our crates with the following errors ``` thread 'rustc' panicked at 'assertion failed: !self.in_new_crate(old)', src/mapping.rs:213:9 ``` ``` thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()',...

> Praise: This looks like the type of hash map impl that will work well in ICU4X. It looks algorithmically similar to the approach rkyv is taking. > > I...

Added some benchmarks reusing the data from the existing ones. Results ``` zeromap/lookup/large time: [188.63 ns 188.94 ns 189.27 ns] change: [-2.8188% -2.3026% -1.7709%] (p = 0.00 < 0.05) Performance...

> @pdogr Good data on the large map. How does the performance compare on the small version of the map? For smaller keys hash computation time really comes into picture...

FlexZeroVec vs ZeroVec Using `ZeroVec` improves the lookup time by ~ 11% (99ns -> 87ns) for small lookups and ~25% (82ns -> 64ns) for large lookups with the existing algorithm.

Switched to the practical approach mentioned in that paper with 64 bit (16 bits for g, 24 bits for f0, f1). Changed the hash function to [wyhash](https://github.com/wangyi-fudan/wyhash). Benches ``` zeromap/lookup/small...