Patrick Doane

How does the user distinguish between the generation of a 15.5 vs 15.3? They either need to be different actions or there needs to be another command line option. Compared...

Sometimes we need to know toolset version for gcc/clang though too so it's probably a good opportunity to have a consistent mechanism to handle this issue. That said, from a...

Another issue here is that `toolset` for msc includes version numbers but doesn't for clang/gcc. The android module adds another setting `toolchainversion` which specifies that version number.

With HDR displays becoming more common, ideally we could display the actual color somehow. I think the 2nd suggestion is a better intermediate solution though (passing two colors instead of...

In the future it could be useful to have platform optimized formats. Having a universal solution is important though and the thinking here sounds good.

I'm interested to get parity with the annotators in the A1111 extension. After we get through the current refactoring PRs, I have depth_leres on a branch ready to go. I...

A1111 Implementation is here: https://github.com/Mikubill/sd-webui-controlnet/tree/main/annotator. It is derived from the ControlNet sources similar to this package. There are design differences which I outlined in #43, but two major points would...

This functionality is in the A1111 implementation, e.g. see https://github.com/Mikubill/sd-webui-controlnet/blob/main/annotator/openpose/__init__.py#L122

There's a good chance that the openpose implementations have diverged. I last updated all of them on 5/27 so it's worth a pass to review.

In the original sources, the invert happens here: https://github.com/lllyasviel/ControlNet-v1-1-nightly/blob/main/gradio_lineart.py#L48 The controlnet_aux processor output can be directly used by the model. In the original implementation, most of the code is in...