Pierre De Rop
Pierre De Rop
I forgot to say that I'm using the following java version: java -version java version "1.8.0_66" Java(TM) SE Runtime Environment (build 1.8.0_66-b17) Java HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed...
errata, (oops sorry): for the following example: ``` java Printer printer = new Printer(); Consumer print = printer::println; Class type = TypeResolver.resolveRawArgument(Consumer.class, print.getClass()); System.out.println(type); ``` I would expect the type...
When _ServerTransport.dispose_ method call is done, the server connection is indeed closed (the server does not listen anymore on the server port), that's ok. But when the dispose method returns,...
(the failure CI test on windows is unrelated)
@violetagg , I have tried to clean up the test, and I have validated it using the multipart PR which consistently reproduces the issue, can you please review it ?...
Indeed, I have updated the PR like in [ITTracingHttpServerDecoratorTest](Https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http-brave/src/test/java/reactor/netty/http/brave/ITTracingHttpServerDecoratorTest.java#L42-L48) I also have closed the group, like it is done in [ITTracingHttpServerDecoratorTest.close](https://github.com/reactor/reactor-netty/blob/1.0.x/reactor-netty-http-brave/src/test/java/reactor/netty/http/brave/ITTracingHttpServerDecoratorTest.java#L56-L59) (isn't it also necessary ? else I can revert...
The failed test on windows is not relevant to this PR.
@violetagg , thanks for the review !!
@violetagg , I have rebased to get the #2328 and the CI build has been modified in order to build the Netty Contrib MP before RN.
@violetagg, I think this PR is ready for a review. The other Netty MP PR (https://github.com/netty-contrib/codec-multipart/pull/1) status is also in request-for-review, so I hope Chris or Norman will have some...